[Win][HCM] Missing focus state for Type, Draw, and Image signature areas with Night Sky enabled
Categories
(Firefox :: PDF Viewer, defect, P1)
Tracking
()
People
(Reporter: gmoldovan, Assigned: calixte)
References
(Blocks 1 open bug)
Details
(Keywords: access)
Attachments
(4 files)
Found in:
- Version: 137.0b9
Affected Versions:
- Version: 138.0a1
- Version: 137.0b9
Tested Platform:
- OS: Windows 11
Preconditions:
- Set
pdfjs.enableSignatureEditor
to true in about:config. - Have HCM Night Sky enabled
Steps to reproduce:
- Click the "Add signature" button under the URL bar.
- Click "Add new signature".
- Observe the focus behavior of the Type, Draw, and Image signature areas when navigating through the tabs of the signature modal.
Expected result:
- The Type, Draw, and Image signature areas should have a visible yellow focus indicator as specified in the Figma design.
Actual result:
- The signature areas do not show any visible focus state. (Only Type tabs receives a purple focus with keyboard navigation.)
Regression range:
- Not a regression since is a new feature.
Additional notes:
- Screencast attached to observe the issue
Updated•1 month ago
|
Updated•1 month ago
|
Comment 1•1 month ago
|
||
Updated•1 month ago
|
Assignee | ||
Updated•1 month ago
|
Updated•1 month ago
|
Comment 2•1 month ago
|
||
The patch landed in nightly and beta is affected.
:calixte, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox137
towontfix
.
For more information, please visit BugBot documentation.
Updated•26 days ago
|
Assignee | ||
Comment 3•22 days ago
|
||
Updated•22 days ago
|
Comment 4•22 days ago
|
||
release Uplift Approval Request
- User impact if declined: Some users could have some difficulties to see the signature area in the signature modal
- Code covered by automated testing: no
- Fix verified in Nightly: yes
- Needs manual QE test: no
- Steps to reproduce for manual QE testing:
- Risk associated with taking this patch: low
- Explanation of risk level: Just a css change for a very specific use case
- String changes made/needed: no
- Is Android affected?: no
Updated•22 days ago
|
Reporter | ||
Comment 5•21 days ago
|
||
I’ve verified this issue on Nightly 139.0a1 (20250406090220) and Beta 138.0b3 on Windows 11 with HCM Night Sky enabled.
The fix looks good for the Type and Image tabs. However, on the Draw tab, the focus ring currently includes the "Thickness" control, which does not match the Figma design. According to the spec, the focus outline should only be around the drawing canvas — the thickness control should be excluded from the border.
I’ve attached a comparison screenshot to show the difference between the Figma design and the current behavior in Nightly and Beta.
Is this inclusion of the thickness control in the focus ring intentional?
Assignee | ||
Comment 6•18 days ago
|
||
:Giorgia, yes you're right, I filed bug 1959774 for that: thank you.
Reporter | ||
Comment 7•18 days ago
|
||
Verified as fixed on 138.0b5 and 139.0a1.
The remaining issue with the Draw tab focus ring is being tracked separately in bug 1959774.
Updated•17 days ago
|
Updated•17 days ago
|
Description
•