Closed Bug 1956110 Opened 1 month ago Closed 1 month ago

[Win][HCM] Missing focus state for Type, Draw, and Image signature areas with Night Sky enabled

Categories

(Firefox :: PDF Viewer, defect, P1)

Firefox 138
Desktop
Windows 11
defect

Tracking

()

VERIFIED FIXED
138 Branch
Accessibility Severity s2
Tracking Status
firefox137 --- verified
firefox138 --- verified
firefox139 --- verified

People

(Reporter: gmoldovan, Assigned: calixte)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(4 files)

Found in:

  • Version: 137.0b9

Affected Versions:

  • Version: 138.0a1
  • Version: 137.0b9

Tested Platform:

  • OS: Windows 11

Preconditions:

  • Set pdfjs.enableSignatureEditor to true in about:config.
  • Have HCM Night Sky enabled

Steps to reproduce:

  1. Click the "Add signature" button under the URL bar.
  2. Click "Add new signature".
  3. Observe the focus behavior of the Type, Draw, and Image signature areas when navigating through the tabs of the signature modal.

Expected result:

  • The Type, Draw, and Image signature areas should have a visible yellow focus indicator as specified in the Figma design.

Actual result:

  • The signature areas do not show any visible focus state. (Only Type tabs receives a purple focus with keyboard navigation.)

Regression range:

  • Not a regression since is a new feature.

Additional notes:

  • Screencast attached to observe the issue
Accessibility Severity: --- → s2
Severity: -- → S2
Assignee: nobody → cdenizet
Status: NEW → ASSIGNED
Priority: -- → P1
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch

The patch landed in nightly and beta is affected.
:calixte, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox137 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(cdenizet)
Flags: qe-verify+
Attachment #9477406 - Flags: approval-mozilla-release?

release Uplift Approval Request

  • User impact if declined: Some users could have some difficulties to see the signature area in the signature modal
  • Code covered by automated testing: no
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: Just a css change for a very specific use case
  • String changes made/needed: no
  • Is Android affected?: no
QA Whiteboard: [qa-triaged]
Attached image Focus - Draw tab.PNG

I’ve verified this issue on Nightly 139.0a1 (20250406090220) and Beta 138.0b3 on Windows 11 with HCM Night Sky enabled.

The fix looks good for the Type and Image tabs. However, on the Draw tab, the focus ring currently includes the "Thickness" control, which does not match the Figma design. According to the spec, the focus outline should only be around the drawing canvas — the thickness control should be excluded from the border.

I’ve attached a comparison screenshot to show the difference between the Figma design and the current behavior in Nightly and Beta.

Is this inclusion of the thickness control in the focus ring intentional?

:Giorgia, yes you're right, I filed bug 1959774 for that: thank you.

Flags: needinfo?(cdenizet)

Verified as fixed on 138.0b5 and 139.0a1.
The remaining issue with the Draw tab focus ring is being tracked separately in bug 1959774.

Attachment #9477406 - Flags: approval-mozilla-release? → approval-mozilla-release+

Verified as fixed on 137.0.2.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: